Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593776

[PATCH 00/18] pstore: refactor internal APIs

Show all headers | View raw

For a long time I've been bothered by the complexity of argument passing
in the pstore internals, which makes understanding things and changing
things extremely fragile.

With the proposal of a new backend (EPI capsules), and my attempts to
reorganize things for the proposed multiple-pmsg frontend, I've spent
some time refactoring the internal pstore API to pass a record structure
instead of lots of arguments. This hugely simplifies things, and lets me
document the API better, reduce memory copies, etc.

Included in the series are a few bug fixes as well.

If pstore backend authors could review the changes I've made in their
drivers, I'd appreciate it. Hopefully I got it all right. :) And unless
there are any objections, I'll put this into -next in a couple days.

I intend to continue working on this to fix up the "ecc_notification_size"
field and make it more generalized, and get multiple pmsg support added
too, but I'd like to get this first series out for review first, since
it's rather long already.

Thanks!

-Kees

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] pstore: refactor internal APIs Kees Cook <keescook@chromium.org> - 2017-03-06 23:30 +0100
  [PATCH 10/18] pstore: Replace arguments for write() API Kees Cook <keescook@chromium.org> - 2017-03-06 23:30 +0100
  [PATCH 08/18] pstore: Switch pstore_mkfile to pass record Kees Cook <keescook@chromium.org> - 2017-03-06 23:30 +0100
  [PATCH 04/18] pstore: Improve register_pstore() error reporting Kees Cook <keescook@chromium.org> - 2017-03-06 23:30 +0100
  [PATCH 14/18] pstore: Do not duplicate record metadata Kees Cook <keescook@chromium.org> - 2017-03-07 00:00 +0100
  [PATCH 16/18] pstore: Replace arguments for write_buf() API Kees Cook <keescook@chromium.org> - 2017-03-07 00:00 +0100
  [PATCH 15/18] pstore: Replace arguments for erase() API Kees Cook <keescook@chromium.org> - 2017-03-07 00:00 +0100
  [PATCH 01/18] pstore: Use dynamic spinlock initializer Kees Cook <keescook@chromium.org> - 2017-03-07 00:10 +0100
  [PATCH 17/18] pstore: Replace arguments for write_buf_user() API Kees Cook <keescook@chromium.org> - 2017-03-07 02:00 +0100
  [PATCH 06/18] pstore: Extract common arguments into structure Kees Cook <keescook@chromium.org> - 2017-03-07 03:00 +0100
    Re: [PATCH 06/18] pstore: Extract common arguments into structure Namhyung Kim <namhyung@gmail.com> - 2017-03-07 17:30 +0100
      Re: [PATCH 06/18] pstore: Extract common arguments into structure Kees Cook <keescook@chromium.org> - 2017-03-07 21:40 +0100
  [PATCH 12/18] pstore: Pass record contents instead of copying Kees Cook <keescook@chromium.org> - 2017-03-07 03:20 +0100
  [PATCH 09/18] pstore: Replace arguments for read() API Kees Cook <keescook@chromium.org> - 2017-03-07 05:40 +0100

csiph-web