[PATCH 2/2] f2fs: don't overwrite node block by SSR

From	Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] f2fs: don't overwrite node block by SSR
Date	2017-03-06 23:00 +0100
Message-ID	<ti8PD-5S2-9@gated-at.bofh.it> (permalink)
References	<ti8PD-5S2-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This patch fixes that SSR can overwrite previous warm node block consisting of
a node chain since the last checkpoint.

Fixes: 5b6c6be2d878 ("f2fs: use SSR for warm node as well")
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/segment.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 2ae36d04d03e..684b869e1861 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1177,6 +1177,12 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
 		if (f2fs_discard_en(sbi) &&
 			!f2fs_test_and_set_bit(offset, se->discard_map))
 			sbi->discard_blks--;
+
+		/* don't overwrite by SSR to keep node chain */
+		if (se->type == CURSEG_WARM_NODE) {
+			if (!f2fs_test_and_set_bit(offset, se->ckpt_valid_map))
+				se->ckpt_valid_blocks++;
+		}
 	} else {
 		if (!f2fs_test_and_clear_bit(offset, se->cur_valid_map)) {
 #ifdef CONFIG_F2FS_CHECK_FS
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] f2fs: don't overwrite node block by SSR Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-06 23:00 +0100
  Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR Chao Yu <yuchao0@huawei.com> - 2017-03-08 13:40 +0100
    Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-08 23:10 +0100
      Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR Chao Yu <yuchao0@huawei.com> - 2017-03-09 13:10 +0100

csiph-web