Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API

From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API
Date	2017-03-06 19:00 +0100
Message-ID	<ti55n-3aP-7@gated-at.bofh.it> (permalink)
References	<tgVKN-1Vk-7@gated-at.bofh.it> <tgW49-2iG-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Tomeu,

Pardon for dropping in late.

On 3 March 2017 at 13:39, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Implement the .set_crc_source() callback and call the DP helpers
> accordingly to start and stop CRC capture.
>
> This is only done if this CRTC is currently using the eDP connector.
>
> v3: Remove superfluous check on rockchip_crtc_state->output_type
>
> v6: Remove superfluous variable
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
I think this won't fly (build).

Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is
the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps
adding a simple wrapper/stubs will be the easier option here ?

-Emil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2017-03-03 15:10 +0100
  Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API Mark yao <mark.yao@rock-chips.com> - 2017-03-06 02:10 +0100
  Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API Emil Velikov <emil.l.velikov@gmail.com> - 2017-03-06 19:00 +0100

csiph-web