Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1593538
| From | Pablo Neira Ayuso <pablo@netfilter.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] netfilter: remove redundant check on ret being non-zero |
| Date | 2017-03-06 18:10 +0100 |
| Message-ID | <ti4iZ-2PO-1@gated-at.bofh.it> (permalink) |
| References | <tfOim-3OY-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 28, 2017 at 11:31:15AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ret is initialized to zero and if it is set to non-zero in the
> xt_entry_foreach loop then we exit via the out_free label. Hence
> the check for ret being non-zero is redundant and can be removed.
>
> Detected by CoverityScan, CID#1357132 ("Logically Dead Code")
Applied, thanks.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] netfilter: remove redundant check on ret being non-zero Pablo Neira Ayuso <pablo@netfilter.org> - 2017-03-06 18:10 +0100
csiph-web