Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593535

Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size

Show all headers | View raw

On Mon, Mar 06, 2017 at 02:56:14PM +0000, Marc Zyngier wrote:
> On Mon, Mar 06 2017 at  1:41:06 pm GMT, Franck Demathieu <fdemathieu@gmail.com> wrote:
> > The 'size' variable is unsigned according to the dt-bindings.
> > As this variable is used as integer in other places, create a new variable
> > that allows to fix the following sparse issue (-Wtypesign):
> >
> >   drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness)
> >   drivers/irqchip/irq-crossbar.c:279:52:    expected unsigned int [usertype] *out_value
> >   drivers/irqchip/irq-crossbar.c:279:52:    got int *<noident>
> >
> > Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
> 
> Are you sitting on more of these patches? If so, could you send them as
> a series instead of one a week? It would make a lot more sense to merge
> them in one go.
> 
> Thanks,
> 
> 	M.
> -- 
> Jazz is not dead, it just smell funny.

irq-crossbar.c is now clean from sparse point-of-view, do not expect
more patches there.

Regards,
F.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: crossbar: Fix incorrect type of register size Franck Demathieu <fdemathieu@gmail.com> - 2017-03-06 14:50 +0100
  Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size Marc Zyngier <marc.zyngier@arm.com> - 2017-03-06 16:10 +0100
    Re: [PATCH] irqchip: crossbar: Fix incorrect type of register size Franck Demathieu <fdemathieu@gmail.com> - 2017-03-06 18:00 +0100

csiph-web