Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t
Date	2017-03-06 17:40 +0100
Message-ID	<ti3PY-2mY-7@gated-at.bofh.it> (permalink)
References	<ti1O9-Yn-3@gated-at.bofh.it> <ti1O9-Yn-5@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello.

On 03/06/2017 05:20 PM, Elena Reshetova wrote:

> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
>
> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: David Windsor <dwindsor@gmail.com>
[...]
> diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
> index 115414c..16c1313 100644
> --- a/drivers/media/pci/cx88/cx88.h
> +++ b/drivers/media/pci/cx88/cx88.h
> @@ -24,6 +24,7 @@
>  #include <linux/i2c-algo-bit.h>
>  #include <linux/videodev2.h>
>  #include <linux/kdev_t.h>
> +#include <linux/refcount.h>
>
>  #include <media/v4l2-device.h>
>  #include <media/v4l2-fh.h>
> @@ -339,7 +340,7 @@ struct cx8802_dev;
>
>  struct cx88_core {
>  	struct list_head           devlist;
> -	atomic_t                   refcount;
> +	refcount_t                   refcount;

    Could you please keep the name aligned with above and below?

>
>  	/* board name */
>  	int                        nr;
>

MBR, Sergei

Thread

[PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-06 15:30 +0100
  Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from  atomic_t to refcount_t Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-06 17:40 +0100
    RE: [PATCH 11/29] drivers, media: convert cx88_core.refcount from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-03-07 09:00 +0100
      Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from  atomic_t to refcount_t Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-07 12:00 +0100
  Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from  atomic_t to refcount_t Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-07 09:30 +0100

csiph-web