Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593486

Re: [PATCH] Bluetooth: btqcomsmd: fix compile-test dependency

Show all headers | View raw

Hello Arnd,

On 03/01/2017 07:48 PM, Arnd Bergmann wrote:
> compile-testing fails when QCOM_SMD is a loadable module:
> 
> drivers/bluetooth/built-in.o: In function `btqcomsmd_send':
> btqca.c:(.text+0xa8): undefined reference to `qcom_smd_send'
> drivers/bluetooth/built-in.o: In function `btqcomsmd_probe':
> btqca.c:(.text+0x3ec): undefined reference to `qcom_wcnss_open_channel'
> btqca.c:(.text+0x46c): undefined reference to `qcom_smd_set_drvdata'
> 
> This clarifies the dependency to allow compile-testing only when
> SMD is completely disabled, otherwise the dependency on QCOM_SMD
> will make sure we can link against it.
> 
> Fixes: e27ee2b16bad ("Bluetooth: btqcomsmd: Allow driver to build if COMPILE_TEST is enabled")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for the fix. The patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Bluetooth: btqcomsmd: fix compile-test dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-02 00:00 +0100
  Re: [PATCH] Bluetooth: btqcomsmd: fix compile-test dependency Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-06 16:50 +0100

csiph-web