Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1593469

Re: [PATCH] HID: hid-multitouch: change for touch height/width

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] HID: hid-multitouch: change for touch height/width
Date 2017-03-06 16:20 +0100
Message-ID <ti2Ax-1yj-3@gated-at.bofh.it> (permalink)
References <thRF7-1TU-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 6 Mar 2017, hn.chen@weidahitech.com wrote:

> From: HungNien Chen <hn.chen@weidahitech.com>
> 
> Just quote from Jonathan Clarke in previous thread(2017/01/24):
> "This division by 2 was added along with the touch width/height
> fields 6 years ago so that those fields 'match the visual scale
> of the touch' for a specific device (3M PCT)"
> "The scaling is also discarding information about touch size
> (1 bit for each of width/height) which is useful for any
> application that wants to know about it."
> 
> Jonathan mentioned just what I thought in a new project recently.
> It dosen't make sense to discard 1 bit width/height in general
> case according to the spec in multi-touch-protocol.txt so
> I would like to make a slight change here.
> 
> A quirk MT_QUIRK_TOUCH_SIZE_SCALING was added to service
> devices like 3M PCT with a special visual scale and
> the division by 2 only take effect with devices like that.

I've reformatted the changelog a bit and applied to for-4.12/multitouch. 
Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] HID: hid-multitouch: change for touch height/width <hn.chen@weidahitech.com> - 2017-03-06 04:40 +0100
  Re: [PATCH] HID: hid-multitouch: change for touch height/width Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-06 09:30 +0100
  Re: [PATCH] HID: hid-multitouch: change for touch height/width Jiri Kosina <jikos@kernel.org> - 2017-03-06 16:20 +0100

csiph-web