Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593281

Re: [PATCH] mac80211: Use setup_timer instead of init_timer

Show all headers | View raw

On 03/06/2017, 01:25 PM, Johannes Berg wrote:
> On Fri, 2017-03-03 at 13:45 +0100, Jiri Slaby wrote:
>> From: Ondřej Lysoněk <ondrej.lysonek@seznam.cz>
>>
>> Use setup_timer() and setup_deferrable_timer() to set the data and
>> function timer fields. It makes the code cleaner and will allow for
>> easier change of the timer struct internals.
> 
> Btw, I suspect you generated this with coccinelle and didn't put enough
> "..." there, because you missed one in mesh_path_new() :)

Not really. This is one of assignments for students I lead, so this is
done by hand every end of winter semester (Note the From line.)

> Care to send a patch for that one too?

I am just a forwarder, he received this request too, so you can try to
persuade him :).

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: Use setup_timer instead of init_timer Jiri Slaby <jslaby@suse.cz> - 2017-03-03 13:50 +0100
  Re: [PATCH] mac80211: Use setup_timer instead of init_timer Johannes Berg <johannes@sipsolutions.net> - 2017-03-06 13:40 +0100
  Re: [PATCH] mac80211: Use setup_timer instead of init_timer Jiri Slaby <jslaby@suse.cz> - 2017-03-06 13:40 +0100
  Re: [PATCH] mac80211: Use setup_timer instead of init_timer Johannes Berg <johannes@sipsolutions.net> - 2017-03-06 14:10 +0100
    Re: [PATCH] mac80211: Use setup_timer instead of init_timer Johannes Berg <johannes@sipsolutions.net> - 2017-03-06 14:10 +0100
  Re: [PATCH] mac80211: Use setup_timer instead of init_timer Johannes Berg <johannes@sipsolutions.net> - 2017-03-06 14:10 +0100

csiph-web