Re: [PATCHv2 09/10] drm: omapdrm: crtc: get manual mode displays working

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 09/10] drm: omapdrm: crtc: get manual mode displays working
Date	Sun, 05 Mar 2017 06:50:02 +0100
Message-ID	<thxdo-3TP-7@gated-at.bofh.it> (permalink)
References	<thrKF-8kZ-5@gated-at.bofh.it> <thsx3-rY-3@gated-at.bofh.it> <thsx4-rY-25@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.2 (2016-11-26)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	Aaro Koskinen <aaro.koskinen@iki.fi>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, David Airlie <airlied@linux.ie>, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 4 Mar 2017 21:39:51 -0800
X-Original-Message-ID	<20170305053951.GB20572@atomide.com>
X-Original-References	<20170304235021.27055-1-sre@kernel.org> <20170305004309.28259-1-sre@kernel.org> <20170305004309.28259-9-sre@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1592699

Show key headers only | View raw

* Sebastian Reichel <sre@kernel.org> [170304 16:45]:
> From: Tony Lindgren <tony@atomide.com>
> 
> With manual mode displays we need to flush the panel manually.
> 
> Let's add flushing so we get Tomi's fbtest, kmstest, kmstest --flip,
> and X and wayland working.
> --- a/drivers/gpu/drm/omapdrm/omap_crtc.c
> +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
> @@ -97,6 +97,11 @@ bool omap_crtc_is_manual_updated(struct drm_crtc *crtc)
>  	return omap_crtc->manually_updated;
>  }
>  
> +static void omap_crtc_manual_needs_flush(struct drm_crtc *crtc)
> +{
> +	omap_crtc_flush(crtc, 0, 0, 0, 0);
> +}
...

> @@ -554,6 +561,7 @@ static void omap_crtc_atomic_flush(struct drm_crtc *crtc,
>  		ret = drm_crtc_vblank_get(crtc);
>  		WARN_ON(ret != 0);
>  	}
> +	omap_crtc_flush(&omap_crtc->base, 0, 0, 0, 0);

Just noticed that this should also just use omap_crtc_manual_needs_flush()
here if you care to update it.

Regards,

Tony

Thread

[PATCHv2 00/10] Nokia N950 basic display support Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:00 +0100
  [PATCHv2 03/10] Revert "drm: omapdrm: Remove manual update display support" Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
  [PATCHv2 07/10] drm: omapdrm: plane: update fifo size on atomic update Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
  [PATCHv2 01/10] drm: omapdrm: panel-dsi-cm: Fix probe for device tree Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
    [PATCHv2 08/10] drm: omapdrm: crtc: handle framedone directly Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
    [PATCHv2 05/10] drm: omapdrm: crtc: detect manually updated displays Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
      Re: [PATCHv2 05/10] drm: omapdrm: crtc: detect manually updated  displays Tony Lindgren <tony@atomide.com> - 2017-03-05 06:50 +0100
    [PATCHv2 10/10] ARM: dts: n950: add display support Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
    [PATCHv2 09/10] drm: omapdrm: crtc: get manual mode displays working Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
      Re: [PATCHv2 09/10] drm: omapdrm: crtc: get manual mode displays  working Tony Lindgren <tony@atomide.com> - 2017-03-05 06:50 +0100
    [PATCHv2 04/10] drm: omapdrm: crtc: save framedone callback from dss Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
      Re: [PATCHv2 04/10] drm: omapdrm: crtc: save framedone callback from  dss Tony Lindgren <tony@atomide.com> - 2017-03-05 06:50 +0100
    [PATCHv2 02/10] drm: omapdrm: panel-dsi-cm: add regulator support Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100
      Re: [PATCHv2 02/10] drm: omapdrm: panel-dsi-cm: add regulator support Tony Lindgren <tony@atomide.com> - 2017-03-05 06:50 +0100
    [PATCHv2 06/10] drm: omapdrm: crtc: add support for manual updated displays Sebastian Reichel <sre@kernel.org> - 2017-03-05 01:50 +0100

csiph-web