Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592600

Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for keymap copy

Show all headers | View raw

On Thu, Mar 2, 2017 at 2:02 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> Some platform drivers use devm_input_allocate_device() together with
> sparse_keymap_setup() in their .probe callbacks.  While using the former
> simplifies error handling, using the latter necessitates calling
> sparse_keymap_free() in the error path and upon module unloading to
> avoid leaking the copy of the keymap allocated by sparse_keymap_setup().
>
> To help prevent such leaks and enable simpler error handling, make
> sparse_keymap_setup() use devm_kcalloc() to allocate memory for the
> keymap copy so that it gets automatically freed.

> + * Since sparse_keymap_setup() now uses a managed allocation for the
> + * keymap copy, use of this function is deprecated.

So...

>   */
>  void sparse_keymap_free(struct input_dev *dev)

... add __deprecated then?

>  {

>  }
>  EXPORT_SYMBOL(sparse_keymap_free);

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Input: sparse-keymap - use a managed allocation for keymap copy Michał Kępień <kernel@kempniu.pl> - 2017-03-02 15:10 +0100
  Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-04 19:00 +0100
    Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Michał Kępień <kernel@kempniu.pl> - 2017-03-06 08:20 +0100
      Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-06 08:50 +0100
        Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Michał Kępień <kernel@kempniu.pl> - 2017-03-07 09:20 +0100
    Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-07 19:50 +0100
  Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for  keymap copy Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-07 19:20 +0100

csiph-web