Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592526

[PATCH 2/6] staging: speakup: Avoid multiple assignments on same line

From Arushi Singhal <arushisinghal19971997@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/6] staging: speakup: Avoid multiple assignments on same line
Date 2017-03-04 17:00 +0100
Message-ID <thkga-2TF-23@gated-at.bofh.it> (permalink)
References <thkga-2TF-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/speakup/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 47cea629ba0b..604335390b87 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2091,7 +2091,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 			spk_keydown = 0;
 			goto out;
 		}
-		value = spk_lastkey = pad_chars[value];
+		value = pad_chars[value];
+		spk_lastkey = value;
 		spk_keydown++;
 		spk_parked &= 0xfe;
 		goto no_map;
-- 
2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] multiple checkpatch issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 2/6] staging: speakup: Avoid multiple assignments on same line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 4/6] staging: wilc1000: Alignment should match open parenthesis Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 1/6] staging: speakup: fixes braces {} should be used on all arms of this statement Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 3/6] staging: speakup: identation should use tabs Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 6/6] staging: wilc1000: Logical continuations should be on the previous line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100
  [PATCH 5/6] staging: wilc1000: function prototype argument should have identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-04 17:00 +0100

csiph-web