Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592569

[PATCH 01/12] gpio: mockup: use devm_irq_alloc_descs()

Show all headers | View raw

Use the resource managed variant of irq_alloc_descs(). This allows us
to remove gpio_mockup_remove().

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpio-mockup.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 06dac72..37c2d69 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -169,7 +169,7 @@ static int gpio_mockup_irqchip_setup(struct device *dev,
 	struct gpio_chip *gc = &chip->gc;
 	int irq_base, i;
 
-	irq_base = irq_alloc_descs(-1, 0, gc->ngpio, 0);
+	irq_base = devm_irq_alloc_descs(dev, -1, 0, gc->ngpio, 0);
 	if (irq_base < 0)
 		return irq_base;
 
@@ -373,25 +373,11 @@ static int gpio_mockup_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int gpio_mockup_remove(struct platform_device *pdev)
-{
-	struct gpio_mockup_chip *chips;
-	int i;
-
-	chips = platform_get_drvdata(pdev);
-
-	for (i = 0; i < gpio_mockup_params_nr >> 1; i++)
-		irq_free_descs(chips[i].gc.irq_base, chips[i].gc.ngpio);
-
-	return 0;
-}
-
 static struct platform_driver gpio_mockup_driver = {
 	.driver = {
 		.name = GPIO_MOCKUP_NAME,
 	},
 	.probe = gpio_mockup_probe,
-	.remove = gpio_mockup_remove,
 };
 
 static struct platform_device *pdev;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] gpio: use resource management for irq descriptors Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 12/12] gpio: sta2x11: use resource management for irqs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 07/12] gpio: pxa: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
    Re: [PATCH 07/12] gpio: pxa: use devm_irq_alloc_descs() Robert Jarzmik <robert.jarzmik@free.fr> - 2017-03-04 21:40 +0100
  [PATCH 05/12] gpio: ml-ioh: use resource management for irqs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 08/12] gpio: davinci: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
    Re: [PATCH 08/12] gpio: davinci: use devm_irq_alloc_descs() Keerthy <j-keerthy@ti.com> - 2017-03-06 06:10 +0100
  [PATCH 04/12] gpio: pch: use resource management for irqs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 01/12] gpio: mockup: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
    Re: [PATCH 01/12] gpio: mockup: use devm_irq_alloc_descs() Bamvor Zhang Jian <bamvor.zhangjian@linaro.org> - 2017-03-08 09:30 +0100
  [PATCH 09/12] gpio: sodaville: use resource management for irqs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 11/12] gpio: mxs: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 02/12] gpio: twl4030: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 06/12] gpio: xlp: use resource management for irqs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 17:40 +0100
  [PATCH 03/12] gpio: omap: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 18:00 +0100
    Re: [PATCH 03/12] gpio: omap: use devm_irq_alloc_descs() Tony Lindgren <tony@atomide.com> - 2017-03-06 18:00 +0100
  [PATCH 10/12] gpio: mxc: use devm_irq_alloc_descs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-03-04 19:30 +0100

csiph-web