Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1593253
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info |
| Date | 2017-03-06 13:10 +0100 |
| Message-ID | <thZCG-7XE-7@gated-at.bofh.it> (permalink) |
| References | <thZjk-7C0-7@gated-at.bofh.it> <thZjk-7C0-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Mar 6, 2017 at 1:40 PM, Christian König <deathsimple@vodafone.de> wrote:
> From: Christian König <christian.koenig@amd.com>
>
> The address is 64bit, not 32bit.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index bf31aaf..a470869 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -385,7 +385,7 @@ static int amdgpu_doorbell_init(struct amdgpu_device *adev)
> if (adev->doorbell.ptr == NULL) {
> return -ENOMEM;
> }
> - DRM_INFO("doorbell mmio base: 0x%08X\n", (uint32_t)adev->doorbell.base);
> + DRM_INFO("doorbell mmio base: 0x%llX\n", (uint64_t)adev->doorbell.base);
> DRM_INFO("doorbell mmio size: %u\n", (unsigned)adev->doorbell.size);
It seems I sent patch to remove those at all, but if you wish to leave
them, please convert to %pap and remove explicit casting.
--
With Best Regards,
Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/5] PCI: add resizeable BAR infrastructure v2 Christian König <deathsimple@vodafone.de> - 2017-03-06 12:50 +0100
[PATCH 3/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors Christian König <deathsimple@vodafone.de> - 2017-03-06 12:50 +0100
[PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info Christian König <deathsimple@vodafone.de> - 2017-03-06 12:50 +0100
Re: [PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-06 13:10 +0100
Re: [PATCH 4/5] drm/amdgpu: fix printing the doorbell BAR info Christian König <deathsimple@vodafone.de> - 2017-03-06 13:30 +0100
[PATCH 2/5] PCI: add functionality for resizing resources Christian König <deathsimple@vodafone.de> - 2017-03-06 12:50 +0100
[PATCH 5/5] drm/amdgpu: resize VRAM BAR for CPU access Christian König <deathsimple@vodafone.de> - 2017-03-06 12:50 +0100
Re: [PATCH 5/5] drm/amdgpu: resize VRAM BAR for CPU access Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-06 13:10 +0100
Re: [PATCH 5/5] drm/amdgpu: resize VRAM BAR for CPU access Christian König <deathsimple@vodafone.de> - 2017-03-06 13:40 +0100
Re: [PATCH 1/5] PCI: add resizeable BAR infrastructure v2 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-06 13:30 +0100
Re: [PATCH 1/5] PCI: add resizeable BAR infrastructure v2 Christian König <deathsimple@vodafone.de> - 2017-03-13 10:50 +0100
csiph-web