Re: [PATCH v2 0/4] fujitsu_init() cleanup

From	Jonathan Woithe <jwoithe@just42.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/4] fujitsu_init() cleanup
Date	2017-03-06 10:00 +0100
Message-ID	<thWEO-5Iw-11@gated-at.bofh.it> (permalink)
References	<tg7El-dA-3@gated-at.bofh.it> <th7iV-1Id-1@gated-at.bofh.it> <thOxA-8cZ-3@gated-at.bofh.it> <thSUx-2Fb-3@gated-at.bofh.it> <thT4d-2Xw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Michael

Some quick feedback.

On Mon, Mar 06, 2017 at 03:31:04PM +1030, Jonathan Woithe wrote:
> > > I can add that immediately after loading the driver the value returned by a
> > > read of bl_power is 0.  As noted above, setting to 1 makes no difference to
> > > the backlight, neither does returning it to 0.
> > 
> > Have you tried setting bl_power to 4?  Because that is the value of
> > FB_BLANK_POWERDOWN, which is the value the patch is supposed to handle.
> 
> Oh no, I didn't try 4.  I should have.  I will try to squeeze in a test of
> this tonight (time is short but the test won't take a lot of time).

With an unpatched 4.5 kernel, writing 4 (as opposed to 1, which I stupidly
tried earlier) to bl_power caused the backlight to turn off.  Writing 0
turned it back on again.

With patches 1-4/4 applied, writing 4 to bl_power did *NOT* turn the
backlight off.

With patch 2 reverted, writing 4 to bl_power turned the backlight off. 
Writing 0 to bl_power turned it back on again.

This means that patch 2/4 seems to prevent bl_power from operating as
expected on the S7020 hardware.  Without this patch (but with all the others
in place) bl_power works.

I am unlikely to have any more time to investigate this further tonight. 

In light of the above findings, what would you like to do?

Regards
  jonathan

Thread

[PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-01 09:20 +0100
  [PATCH v2 1/4] platform/x86: fujitsu-laptop: register backlight device in a separate function Michał Kępień <kernel@kempniu.pl> - 2017-03-01 09:20 +0100
  [PATCH v2 2/4] platform/x86: fujitsu-laptop: do not use call_fext_func() for LCD blanking Michał Kępień <kernel@kempniu.pl> - 2017-03-01 09:20 +0100
  [PATCH v2 3/4] platform/x86: fujitsu-laptop: only register backlight device if FUJ02B1 is present Michał Kępień <kernel@kempniu.pl> - 2017-03-01 09:20 +0100
  Re: [PATCH v2 0/4] fujitsu_init() cleanup [resend due to vger error] Jonathan Woithe <jwoithe@just42.net> - 2017-03-02 04:50 +0100
  Re: [PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-02 09:30 +0100
    Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-03 13:50 +0100
  Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-04 03:10 +0100
    Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-06 01:20 +0100
      Re: [PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-06 06:00 +0100
        Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-06 06:10 +0100
          Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-06 10:00 +0100
            Re: [PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-06 10:40 +0100
              Re: [PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-06 19:50 +0100
                Re: [PATCH v2 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-03-07 05:00 +0100
                Re: [PATCH v2 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-03-07 09:20 +0100

csiph-web