Re: [linux-sunxi] [PATCH v2 11/12] ARM: dts: sun8i: add pinmux for V3s mmc1

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] [PATCH v2 11/12] ARM: dts: sun8i: add pinmux for V3s mmc1
Date	2017-03-06 05:30 +0100
Message-ID	<thSrv-2vb-3@gated-at.bofh.it> (permalink)
References	<thRYt-20v-5@gated-at.bofh.it> <thSrv-2vb-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Mar 5, 2017 at 9:37 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
> Allwinner V3s SoC features 3 MMC controllers, mmc0 is used as the
> MicroSD slot on Lichee Pi Zero, and on Lichee Pi Zero's dock mmc1 is
> also soldered as a MicroSD slot.
>
> Add the pinmux for mmc1, thus we can enable the MicroSD slot on the
> Lichee Pi Zero dock.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 5fb6cb69f7bc..a39c26bceedc 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -234,6 +234,14 @@
>                                 drive-strength = <30>;
>                                 bias-pull-up;
>                         };
> +
> +                       mmc1_pins: mmc1@0 {

This seems to be the only possible configuration. In that case, please drop
the @0 from the node name. We shouldn't be adding them anyway, since it causes
warnings from the device tree compiler.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> +                               pins = "PG0", "PG1", "PG2", "PG3",
> +                                      "PG4", "PG5";
> +                               function = "mmc1";
> +                               drive-strength = <30>;
> +                               bias-pull-up;
> +                       };
>                 };
>
>                 timer@01c20c00 {
> --
> 2.11.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [linux-sunxi] [PATCH v2 11/12] ARM: dts: sun8i: add pinmux for  V3s mmc1 Chen-Yu Tsai <wens@csie.org> - 2017-03-06 05:30 +0100

csiph-web