Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event
Date	2017-03-05 23:50 +0100
Message-ID	<thN8t-76h-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <tgI1b-KT-3@gated-at.bofh.it> <tgU2m-FV-25@gated-at.bofh.it> <th4l4-7SF-11@gated-at.bofh.it> <thfzP-7W2-7@gated-at.bofh.it> <thsnn-mO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote:
> 
> 
> On 03/04/2017 02:56 AM, Sakari Ailus wrote:
> >That's a bit of a special situation --- still there are alike conditions on
> >existing hardware. You should return the buffers to the user with the ERROR
> >flag set --- or return -EIO from VIDIOC_DQBUF, if the condition will
> >persist:
> 
> On i.MX an EOF timeout is not recoverable without a stream restart, so
> I decided to call vb2_queue_error() when the timeout occurs (instead
> of sending an event). The user will then get -EIO when it attempts to
> queue or dequeue further buffers.

I'm not sure that statement is entirely accurate.  With the IMX219
camera, I _could_ (with previous iterations of the iMX capture code)
stop it streaming, wait a while, and restart it, and everything
continues to work.

Are you sure that the problem you have here is caused by the iMX6
rather than the ADV718x CVBS decoder (your initial description said
it was the decoder.)

If it _is_ the decoder that's going wrong, that doesn't justify
cripping the rest of the driver for one instance of broken hardware
that _might_ be attached to it.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Thread

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 17:10 +0100
  Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Steve Longerbeam <slongerbeam@gmail.com> - 2017-03-03 00:10 +0100
    Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-03 13:00 +0100
      Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Steve Longerbeam <slongerbeam@gmail.com> - 2017-03-04 00:00 +0100
        Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-04 12:00 +0100
          Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Steve Longerbeam <slongerbeam@gmail.com> - 2017-03-05 01:40 +0100
            Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-05 22:50 +0100
            Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-03-05 23:50 +0100
              Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Steve Longerbeam <slongerbeam@gmail.com> - 2017-03-10 03:40 +0100
                Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-03-10 11:00 +0100

csiph-web