Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592770

Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

Show all headers | View raw

Philippe Reynes <tremyfr@gmail.com> writes:

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> Changelog:
> v2:
> - also update comment (feeback from Russel King)

Ok, I tested it, with :
    ethtool -s eth0 duplex half autoneg off speed 10
    ethtool eth0
       => see the changes
    ping -f x.x.x.x
    ethtool -s eth0 duplex full autoneg on
    ethtool eth0
       => see the changes
    ping -f x.x.x.x

This both with your patch and without, it works in both cases, and the former as
a smaller throughput, which makes me believe the patch is fine.

Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2017-03-04 12:50 +0100
  Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Robert Jarzmik <robert.jarzmik@free.fr> - 2017-03-05 15:30 +0100
  Re: [PATCH v2] net: smsc: smc91x: use new api  ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2017-03-09 07:10 +0100

csiph-web