Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592318

Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API

From Richard Weinberger <richard@nod.at>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API
Date 2017-03-03 23:30 +0100
Message-ID <th3S1-7Ef-9@gated-at.bofh.it> (permalink)
References (2 earlier) <tgGiK-80q-1@gated-at.bofh.it> <tgUF4-1cK-9@gated-at.bofh.it> <tgVKO-1Vk-9@gated-at.bofh.it> <tgWdQ-2m3-5@gated-at.bofh.it> <tgWdQ-2m3-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am 03.03.2017 um 15:11 schrieb Boris Brezillon:
>> And add a list of successfully added notifiers, along with their
>> data pointer, to the MTD device. That's simple and would also remove
>> the need for notifier to have a private list of their instances as I
>> had to do here.
> 
> And then you're abusing the notifier concept. As said earlier, a
> notifier is not necessarily using the device, and thus, don't
> necessarily need private data.
> It's not only about what is the simplest solution for your use case,
> but also what other users want/need.

Yes, please don't use the mtd_notifier.
I strongly vote to embed the nvmem pointer into struct mtd_info.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API Alban <albeu@free.fr> - 2017-03-02 21:00 +0100
  Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-02 22:20 +0100
    Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Alban <albeu@free.fr> - 2017-03-03 13:40 +0100
      Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-03 14:50 +0100
        Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-03 15:20 +0100
          Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Richard Weinberger <richard@nod.at> - 2017-03-03 23:30 +0100
            Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Alban <albeu@free.fr> - 2017-03-06 18:30 +0100
              Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Richard Weinberger <richard@nod.at> - 2017-03-06 20:10 +0100
                Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-06 22:10 +0100
        Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Alban <albeu@free.fr> - 2017-03-03 21:00 +0100
  Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-03-03 12:30 +0100
    Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-03 13:50 +0100
      Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Alban <albeu@free.fr> - 2017-03-03 14:40 +0100
        Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the  nvmem API Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-03 15:20 +0100

csiph-web