Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement
Date	2017-03-03 21:20 +0100
Message-ID	<th1Qe-6jM-29@gated-at.bofh.it> (permalink)
References	<th0r7-5c2-5@gated-at.bofh.it> <th0r8-5c2-25@gated-at.bofh.it> <th0r8-5c2-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-03-03 at 19:40 +0100, Julia Lawall wrote:
> On Sat, 4 Mar 2017, Arushi Singhal wrote:
> > This patch fixes the checks reported by checkpatch.pl
> > for braces {} should be used on all arms of this statement.
> > 
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> >  drivers/staging/speakup/main.c | 29 +++++++++++++++++++----------
> >  1 file changed, 19 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index 7915e75664f4..6179e0aafa25 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -640,8 +640,9 @@ static void say_prev_word(struct vc_data *vc)
> >  				break;
> >  			spk_y--;
> >  			spk_x = vc->vc_cols - 1;
> > -		} else
> > +		} else{
> 
> else needs a space after it.

And if you had scanned this suggested patch with
checkpatch, you would have known that.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces  {} should be used on all arms of this statement Julia Lawall <julia.lawall@lip6.fr> - 2017-03-03 19:50 +0100
  Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces  {} should be used on all arms of this statement Joe Perches <joe@perches.com> - 2017-03-03 21:20 +0100

csiph-web