Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592268

[PATCH 4/6] staging: speakup: Avoid multiple assignments on same line

Show all headers | View raw

This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/speakup/main.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index c1c3ee7dc95a..6c21ae1ae2d3 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -269,9 +269,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
 
 static void speakup_date(struct vc_data *vc)
 {
-	spk_x = spk_cx = vc->vc_x;
-	spk_y = spk_cy = vc->vc_y;
-	spk_pos = spk_cp = vc->vc_pos;
+	spk_x = vc->vc_x;
+	spk_cx = spk_x;
+	spk_y = vc->vc_y;
+	spk_cy = spk_y;
+	spk_pos = vc->vc_pos;
+	spk_cp = spk_pos;
 	spk_old_attr = spk_attr;
 	spk_attr = get_attributes(vc, (u_short *)spk_pos);
 }
@@ -1643,9 +1646,12 @@ static int speak_highlight(struct vc_data *vc)
 		spk_do_flush();
 		spkup_write(speakup_console[vc_num]->ht.highbuf[hc],
 			    speakup_console[vc_num]->ht.highsize[hc]);
-		spk_pos = spk_cp = speakup_console[vc_num]->ht.rpos[hc];
-		spk_x = spk_cx = speakup_console[vc_num]->ht.rx[hc];
-		spk_y = spk_cy = speakup_console[vc_num]->ht.ry[hc];
+		spk_pos = speakup_console[vc_num]->ht.rpos[hc];
+		spk_cp = speakup_console[vc_num]->ht.rpos[hc];
+		spk_x = speakup_console[vc_num]->ht.rx[hc];
+		spk_cx = speakup_console[vc_num]->ht.rx[hc];
+		spk_y = speakup_console[vc_num]->ht.ry[hc];
+		spk_cy = speakup_console[vc_num]->ht.ry[hc];
 		return 1;
 	}
 	return 0;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] multiple checkpatch issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100
  [PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100
    Re: [PATCH 1/6] staging: speakup: Add blank line after  function/struct/union/enum declarations Greg KH <gregkh@linuxfoundation.org> - 2017-03-09 14:30 +0100
      Re: [PATCH 1/6] staging: speakup: Add blank line after  function/struct/union/enum declarations Greg KH <gregkh@linuxfoundation.org> - 2017-03-09 17:30 +0100
  [PATCH 4/6] staging: speakup: Avoid multiple assignments on same line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100
  [PATCH 3/6] staging: speakup: Blank lines removed after an open brace '{' Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100
  [PATCH 6/6] staging: speakup: Comparison to NULL could be written Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100
  [PATCH 2/6] staging: speakup: Logical continuations should be on the previous line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-03 21:20 +0100

csiph-web