Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592235

Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock

Show all headers | View raw

Hello, Tahsin.

On Thu, Mar 02, 2017 at 02:33:11PM -0800, Tahsin Erdogan wrote:
> > And let blkg_create() verify these conditions after releasing and
> > regrabbing the lock.
> >
> > This also means that the init path can simply pass in GFP_KERNEL.
> 
> I tried that approach, but I encountered two issues that complicate things:
> 
> 1) Pushing down blk_queue_bypass(q) check in blkg_create() doesn't
> quite work because when blkcg_init_queue() calls blkg_create(), the
> queue is still in bypassing mode.
>
> 2) Pushing down blkcg_policy_enabled() doesn't work well either,
> because blkcg_init_queue() doesn't have a policy to pass down. We
> could let it pass a NULL parameter but that would make blkg_create
> more ugly.

I see.  It kinda really bothers me that we'll have two different modes
for non-atomic allocations.  Can't we bind both to the policy
parameter?  Skip the checks if policy is NULL?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-01 18:00 +0100
  Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-02 01:20 +0100
  [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-02 04:00 +0100
    Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-02 20:50 +0100
      Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-02 23:50 +0100
        Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-03 20:30 +0100
          [PATCH v3] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-04 02:50 +0100
            Re: [PATCH v3] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-04 20:30 +0100
              Re: [PATCH v4] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-05 15:30 +0100
              [PATCH v4] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-05 15:30 +0100
                Re: [PATCH v4] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-06 21:10 +0100
                [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-09 09:10 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue  spinlock Tejun Heo <tj@kernel.org> - 2017-03-09 19:30 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue  spinlock Jens Axboe <axboe@kernel.dk> - 2017-03-11 23:50 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue  spinlock Jens Axboe <axboe@kernel.dk> - 2017-03-12 00:00 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-12 05:40 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue  spinlock Jens Axboe <axboe@kernel.dk> - 2017-03-13 15:40 +0100
                Re: [PATCH v5] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-13 17:20 +0100
            Re: [lkp-robot] [blkcg] ad63af3cb7: BUG:sleeping_function_called_from_invalid_context_at_mm/slab.h Tahsin Erdogan <tahsin@google.com> - 2017-03-09 09:10 +0100

csiph-web