Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

From	Chris Brannon <chris@the-brannons.com>
Newsgroups	linux.kernel
Subject	Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters
Date	2017-03-03 19:50 +0100
Message-ID	<th0r8-5c2-31@gated-at.bofh.it> (permalink)
References	<tgovv-3Ky-1@gated-at.bofh.it> <tgovw-3Ky-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> This extends the synth buffer slots to 16bit, so as to hold 16bit
> unicode characters.
>
> synth_buffer_getc and synth_buffer_peek now return 16bit characters.
> Speech synthesizers which do not support characters beyond latin1 can
> use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1
> characters before getting or peeking. All synthesizers are made to use
> it for now.
>
> This makes synth_buffer_add take a 16bit character. For simplicity for
> now, synth_printf is left to using latin1 formats and strings.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>


Reviewed-by: Chris Brannon <chris@the-brannons.com>


Looks good to me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch 0/3] speakup: support 16bit unicode screen reading Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-02 03:20 +0100
  [patch 2/3] speakup: convert screen reading to 16bit characters Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-02 03:20 +0100
    Re: [patch 2/3] speakup: convert screen reading to 16bit characters Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-04 10:00 +0100
    Re: [patch 2/3] speakup: convert screen reading to 16bit characters Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-04 10:00 +0100
  [patch 3/3] speakup: add unicode variant of /dev/softsynth Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-02 03:20 +0100
    Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth Chris Brannon <chris@the-brannons.com> - 2017-03-03 19:50 +0100
  [patch 1/3] speakup: extend synth buffer to 16bit unicode characters Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-02 03:20 +0100
    Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters Chris Brannon <chris@the-brannons.com> - 2017-03-03 19:50 +0100

csiph-web