[PATCH v2 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled

From	Peter Huewe <peter.huewe@infineon.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled
Date	2017-03-02 15:10 +0100
Message-ID	<tgzAB-3lq-15@gated-at.bofh.it> (permalink)
References	<tgyOd-2Mh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Abort the transfer with ETIMEDOUT when the TPM signals more than
TPM_RETRY wait states. Continuing with the transfer in this state
will only lead to arbitrary failures in other parts of the code.

Cc: <stable@vger.kernel.org>
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Signed-off-by: Peter Huewe <peter.huewe@infineon.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Benoit Houyere <benoit.houyere@st.com>
---
 drivers/char/tpm/tpm_tis_spi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 062799e04f04..639614f2d415 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -101,6 +101,11 @@ static int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 			goto exit;
 	}
 
+	if (i == TPM_RETRY) {
+		ret = -ETIMEDOUT;
+		goto exit;
+	}
+
 	spi_xfer.cs_change = 0;
 	spi_xfer.len = len;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled Peter Huewe <peter.huewe@infineon.com> - 2017-03-02 15:10 +0100

csiph-web