Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1591046
| From | Mian Yousaf Kaukab <yousaf.kaukab@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level |
| Date | 2017-03-02 13:50 +0100 |
| Message-ID | <tgylc-2jr-25@gated-at.bofh.it> (permalink) |
| References | <tgw02-OJ-9@gated-at.bofh.it> <tgw9H-Sh-5@gated-at.bofh.it> <tgw9H-Sh-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/02/2017 11:24 AM, Auger Eric wrote: > Hi, > > On 02/03/2017 11:01, Mian Yousaf Kaukab wrote: >> Check only if irq domains are available. >> >> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com> >> --- >> drivers/vfio/vfio_iommu_type1.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >> index bd6f293c4ebd..e3ed50e40ead 100644 >> --- a/drivers/vfio/vfio_iommu_type1.c >> +++ b/drivers/vfio/vfio_iommu_type1.c >> @@ -1287,8 +1287,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, >> INIT_LIST_HEAD(&domain->group_list); >> list_add(&group->next, &domain->group_list); >> >> - msi_remap = resv_msi ? irq_domain_check_msi_remap() : >> - iommu_capable(bus, IOMMU_CAP_INTR_REMAP); >> + msi_remap = resv_msi && IS_ENABLED(CONFIG_IRQ_DOMAIN) ? >> + irq_domain_check_msi_remap() : >> + iommu_capable(bus, IOMMU_CAP_INTR_REMAP); > Is that patch actually needed after [PATCH 1/2] irqdomain: add empty > irq_domain_check_msi_remap. irq_domain_check_msi_remap() should be > defined and if you follow my suggestion, would return false. Anyway in > your case resv_msi should be false. I agree its an overkill if resv_msi is guaranteed to be false. What I am unsure about is that, if iommu have IOMMU_RESV_MSI regions that would mean that irq domains are selected in the build. If this is not guaranteed, then we need to add this check. > > Thanks > > Eric BR, Yousaf
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level Auger Eric <eric.auger@redhat.com> - 2017-03-02 11:30 +0100
Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level Mian Yousaf Kaukab <yousaf.kaukab@suse.com> - 2017-03-02 13:50 +0100
Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level Auger Eric <eric.auger@redhat.com> - 2017-03-02 14:50 +0100
Re: [PATCH 2/2] vfio: type1: conditionally check MSI remapping at irq domain level Mian Yousaf Kaukab <yousaf.kaukab@suse.com> - 2017-03-02 17:00 +0100
csiph-web