Re: net/dccp: dccp_create_openreq_child freed held lock

From	Dmitry Vyukov <dvyukov@google.com>
Newsgroups	linux.kernel
Subject	Re: net/dccp: dccp_create_openreq_child freed held lock
Date	2017-03-02 14:10 +0100
Message-ID	<tgyEy-2Jl-13@gated-at.bofh.it> (permalink)
References	<tg9mN-1zt-3@gated-at.bofh.it> <tgewa-4ZE-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 1, 2017 at 4:35 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Wed, Mar 01, 2017 at 10:38:54AM +0100, Dmitry Vyukov escreveu:
>> Hello,
>>
>> I've got the following report while running syzkaller fuzzer on
>> 86292b33d4b79ee03e2f43ea0381ef85f077c760:
>>
>>
>> It seems that dccp_create_openreq_child needs to unlock the sock if
>> dccp_feat_activate_values fails.
>
> Yeah, can you please use the patch below, that mimics the error paths in
> sk_clone_new(), from where I think even the comment about it being a raw
> copy came, but the bh_unlock_sock() didn't?
>
> - Arnaldo
>
> diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c
> index 53eddf99e4f6..d20d948a98ed 100644
> --- a/net/dccp/minisocks.c
> +++ b/net/dccp/minisocks.c
> @@ -122,6 +122,7 @@ struct sock *dccp_create_openreq_child(const struct sock *sk,
>                         /* It is still raw copy of parent, so invalidate
>                          * destructor and make plain sk_free() */
>                         newsk->sk_destruct = NULL;
> +                       bh_unlock_sock(newsk);
>                         sk_free(newsk);
>                         return NULL;
>                 }


Applied the patch on bots. Will report if it happens again.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

net/dccp: dccp_create_openreq_child freed held lock Dmitry Vyukov <dvyukov@google.com> - 2017-03-01 11:10 +0100
  Re: net/dccp: dccp_create_openreq_child freed held lock Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-01 16:40 +0100
    Re: net/dccp: dccp_create_openreq_child freed held lock Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-01 16:50 +0100
    Re: net/dccp: dccp_create_openreq_child freed held lock Dmitry Vyukov <dvyukov@google.com> - 2017-03-02 14:10 +0100

csiph-web