Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1591026
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: mm allocation failure and hang when running xfstests generic/269 on xfs |
| Date | 2017-03-02 13:30 +0100 |
| Message-ID | <tgxp7-1Fi-5@gated-at.bofh.it> (permalink) |
| References | <tg4n7-66C-1@gated-at.bofh.it> <tgmWJ-2z2-3@gated-at.bofh.it> <tgrD3-64c-1@gated-at.bofh.it> <tgxp7-1Fi-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu 02-03-17 19:04:48, Tetsuo Handa wrote:
[...]
> So, commit 5d17a73a2ebeb8d1("vmalloc: back off when the current task is
> killed") implemented __GFP_KILLABLE flag and automatically applied that
> flag. As a result, those who are not ready to fail upon SIGKILL are
> confused. ;-)
You are right! The function is documented it might fail but the code
doesn't really allow that. This seems like a bug to me. What do you
think about the following?
---
From d02cb0285d8ce3344fd64dc7e2912e9a04bef80d Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@suse.com>
Date: Thu, 2 Mar 2017 11:31:11 +0100
Subject: [PATCH] xfs: allow kmem_zalloc_greedy to fail
Even though kmem_zalloc_greedy is documented it might fail the current
code doesn't really implement this properly and loops on the smallest
allowed size for ever. This is a problem because vzalloc might fail
permanently. Since 5d17a73a2ebe ("vmalloc: back off when the current
task is killed") such a failure is much more probable than it used to
be. Fix this by bailing out if the minimum size request failed.
This has been noticed by a hung generic/269 xfstest by Xiong Zhou.
Reported-by: Xiong Zhou <xzhou@redhat.com>
Analyzed-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
fs/xfs/kmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
index 339c696bbc01..ee95f5c6db45 100644
--- a/fs/xfs/kmem.c
+++ b/fs/xfs/kmem.c
@@ -34,6 +34,8 @@ kmem_zalloc_greedy(size_t *size, size_t minsize, size_t maxsize)
size_t kmsize = maxsize;
while (!(ptr = vzalloc(kmsize))) {
+ if (kmsize == minsize)
+ break;
if ((kmsize >>= 1) <= minsize)
kmsize = minsize;
}
--
2.11.0
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Christoph Hellwig <hch@infradead.org> - 2017-03-02 01:40 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Xiong Zhou <xzhou@redhat.com> - 2017-03-02 06:40 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-02 07:50 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 09:50 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Xiong Zhou <xzhou@redhat.com> - 2017-03-02 10:30 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Bob Liu <liubo95@huawei.com> - 2017-03-02 07:50 +0100
Re: mm allocation failure and hang when running xfstests generic/269on xfs Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-03-02 12:50 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-03-02 13:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 13:30 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 13:30 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 14:10 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 15:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 15:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 16:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 16:40 +0100
[PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Michal Hocko <mhocko@kernel.org> - 2017-03-02 16:50 +0100
[PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed Michal Hocko <mhocko@kernel.org> - 2017-03-02 16:50 +0100
Re: [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed Christoph Hellwig <hch@lst.de> - 2017-03-02 17:00 +0100
Re: [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed Brian Foster <bfoster@redhat.com> - 2017-03-02 17:10 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Brian Foster <bfoster@redhat.com> - 2017-03-02 17:10 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Christoph Hellwig <hch@lst.de> - 2017-03-02 17:20 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Michal Hocko <mhocko@kernel.org> - 2017-03-02 17:40 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-03-02 17:50 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Dave Chinner <david@fromorbit.com> - 2017-03-04 00:00 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-03-04 00:30 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Dave Chinner <david@fromorbit.com> - 2017-03-04 05:50 +0100
Re: [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Michal Hocko <mhocko@kernel.org> - 2017-03-06 14:30 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 20:20 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Christoph Hellwig <hch@infradead.org> - 2017-03-02 19:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 20:20 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 16:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 18:40 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster <bfoster@redhat.com> - 2017-03-02 15:00 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko <mhocko@kernel.org> - 2017-03-02 15:10 +0100
Re: mm allocation failure and hang when running xfstests generic/269 on xfs Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-03-02 17:00 +0100
csiph-web