Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap

From	Auger Eric <eric.auger@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap
Date	2017-03-02 11:30 +0100
Message-ID	<tgw9I-Sh-23@gated-at.bofh.it> (permalink)
References	<tgw02-OJ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mian Yousaf,

On 02/03/2017 11:01, Mian Yousaf Kaukab wrote:
> Fix following build error for s390:
> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
> 
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
> ---
>  include/linux/irqdomain.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index 188eced6813e..137817b08cdc 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>  {
>  	return NULL;
>  }
> +static inline bool irq_domain_check_msi_remap(void)
> +{
> +	return true;
By default you should rather return false, reporting there is no MSI
remapping capability on irq domain side. Besides thank you for the fix.

Best Regards

Eric
> +}
>  #endif /* !CONFIG_IRQ_DOMAIN */
>  
>  #endif /* _LINUX_IRQDOMAIN_H */
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Auger Eric <eric.auger@redhat.com> - 2017-03-02 11:30 +0100
  Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Mian Yousaf Kaukab <yousaf.kaukab@suse.com> - 2017-03-02 13:30 +0100
    Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Mian Yousaf Kaukab <yousaf.kaukab@suse.com> - 2017-03-02 14:40 +0100
    Re: [PATCH 1/2] irqdomain: add empty irq_domain_check_msi_remap Auger Eric <eric.auger@redhat.com> - 2017-03-02 15:10 +0100

csiph-web