Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590894

Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu

From "Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups linux.kernel
Subject Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu
Date 2017-03-02 08:40 +0100
Message-ID <tgtvb-7o3-1@gated-at.bofh.it> (permalink)
References <tgtbP-7hM-5@gated-at.bofh.it> <tgtbP-7hM-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On March 02, 2017 2:39 PM Minchan Kim wrote: 
> @@ -1424,7 +1424,8 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>  			} else if (!PageSwapBacked(page)) {
>  				/* dirty MADV_FREE page */

Nit: enrich the comment please.
>  				set_pte_at(mm, address, pvmw.pte, pteval);
> -				ret = SWAP_DIRTY;
> +				SetPageSwapBacked(page);
> +				ret = SWAP_FAIL;
>  				page_vma_mapped_walk_done(&pvmw);
>  				break;
>  			}

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 03/11] mm: remove SWAP_DIRTY in ttu Minchan Kim <minchan@kernel.org> - 2017-03-02 08:20 +0100
  Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-02 08:40 +0100
    Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu Minchan Kim <minchan@kernel.org> - 2017-03-03 04:00 +0100
  Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-02 22:20 +0100
  Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-03-07 15:50 +0100

csiph-web