Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590872

Re: [PATCH 2/2] HID: Remove unnecessary OOM messages

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] HID: Remove unnecessary OOM messages
Date 2017-03-02 08:10 +0100
Message-ID <tgt29-7e2-5@gated-at.bofh.it> (permalink)
References <tgi6K-7yC-7@gated-at.bofh.it> <tgi6K-7yC-5@gated-at.bofh.it> <tgsSt-6RL-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2017-03-02 at 07:51 +0100, Michel Hermier wrote:
> Le 01/03/2017 à 20:19, Joe Perches a écrit :
> > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
[]
> > @@ -224,7 +224,6 @@ static int asus_start_multitouch(struct hid_device *hdev)
> >   
> >   	if (!dmabuf) {
> >   		ret = -ENOMEM;
> > -		hid_err(hdev, "Asus failed to alloc dma buf: %d\n", ret);
> >   		return ret;
> >   	}
> 
> Trivial set and return value missed.

You're welcome to submit a follow-on patch.

The compiler should produce the same code
in any case.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] HID: Remove unnecessary OOM messages Joe Perches <joe@perches.com> - 2017-03-01 20:30 +0100
  Re: [PATCH 2/2] HID: Remove unnecessary OOM messages Michel Hermier <michel.hermier@gmail.com> - 2017-03-02 08:00 +0100
    Re: [PATCH 2/2] HID: Remove unnecessary OOM messages Joe Perches <joe@perches.com> - 2017-03-02 08:10 +0100

csiph-web