Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask()

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask()
Date	2017-03-02 05:20 +0100
Message-ID	<tgqnD-5cO-9@gated-at.bofh.it> (permalink)
References	<tecI9-11o-7@gated-at.bofh.it> <tecI9-11o-5@gated-at.bofh.it> <tevrr-5ZH-1@gated-at.bofh.it> <teCjg-2r5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Sat, Feb 25, 2017 at 01:27:34PM +0900, Namhyung Kim escreveu:
> On Fri, Feb 24, 2017 at 06:08:53PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Feb 24, 2017 at 10:12:49AM +0900, Namhyung Kim escreveu:
> > util/cpumap.c:679:8: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> >   if (0 <= val && val <= 9)
> >         ^~
> > Are you ok with the patch below?
 
> I'd rather change hex_char() instead.  How about this?

Ok, applying by hand, somehow it didn't apply using git-am...

- Arnaldo

> +++ b/tools/perf/util/cpumap.c
> @@ -674,11 +674,11 @@ size_t cpu_map__snprint(struct cpu_map *map, char *buf, size_t size)
>         return ret;
>  }
>  
> -static char hex_char(char val)
> +static char hex_char(unsigned char val)
>  {
> -       if (0 <= val && val <= 9)
> +       if (val < 10)
>                 return val + '0';
> -       if (10 <= val && val < 16)
> +       if (val < 16)
>                 return val - 10 + 'a';
>         return '?';
>  }

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-02 05:20 +0100

csiph-web