Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

From	Peter Xu <peterx@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier
Date	2017-03-02 03:40 +0100
Message-ID	<tgoOR-3VU-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <teuc2-4Ze-9@gated-at.bofh.it> <tfKy5-1gf-5@gated-at.bofh.it> <tfKHM-1jq-9@gated-at.bofh.it> <tgfVf-65H-1@gated-at.bofh.it> <tgnzs-34a-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 02, 2017 at 09:15:33AM +0800, Peter Xu wrote:

[...]

> Meanwhile, I think it's still worthwhile to go through the patch even
> it's from cocinelle since sometimes coccinelle might do something that
> we (or only me?) didn't expect. E.g., afaik it cannot handle well with
> over-80-chars lines, so we need to wrap them on our own (I got a patch
> from the author though to fix this, but not yet tested).

Sorry I should definitely mention that that issue only exists in
special conditions, iirc like printf("string1" "string2") and when the
strings are very long, since I believe in most cases coccinelle works
perfectly well. Thanks,

-- peterx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Radim Krčmář <rkrcmar@redhat.com> - 2017-03-01 18:10 +0100
  Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Peter Xu <peterx@redhat.com> - 2017-03-02 02:20 +0100
    Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Peter Xu <peterx@redhat.com> - 2017-03-02 03:40 +0100

csiph-web