Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays on

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays on
Date	2017-03-02 01:50 +0100
Message-ID	<tgmtI-2mO-13@gated-at.bofh.it> (permalink)
References	<tgb5g-2A8-21@gated-at.bofh.it> <tgcXo-3Po-23@gated-at.bofh.it> <tgiq5-7Fz-17@gated-at.bofh.it> <tgl4B-1eE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 01, 2017 at 02:39:09PM -0800, Sonny Rao wrote:

> > We recently added global suspend/resume callbacks to the TPM
> > core. Those call backs do not power off the TPM, they just prepare its
> > internal state to loose power to the chip. Skipping that process on
> > hardware that does not power-off the TPM makes sense to me.
> >
> > But, Sonny, perhaps this should be a global flag in tpm_chip, not a
> > per-interface-driver override?
> 
> It's a property of the board design not the chip -- maybe I'm
> misunderstanding?

I mean do not add the code to handle this to tpm_i2c_infineon.c but in
the common chip code instead.

tpm_i2c_infineon.c should only parse DT properties that are relavent
to the bus that delivers commands to the TPM, things that apply to how
a TPM chip operates should be handled in the core code because they
apply to any command transport bus.

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: do not suspend/resume if power stays on Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-01 13:00 +0100
  Re: [PATCH] tpm: do not suspend/resume if power stays on Peter Huewe <peterhuewe@gmx.de> - 2017-03-01 13:10 +0100
    Re: [PATCH] tpm: do not suspend/resume if power stays on Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-03-01 13:20 +0100
  Re: [PATCH] tpm: do not suspend/resume if power stays on Mark Rutland <mark.rutland@arm.com> - 2017-03-01 15:00 +0100
    Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays  on Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-01 20:50 +0100
      Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays on Sonny Rao <sonnyrao@chromium.org> - 2017-03-01 23:40 +0100
        Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays on Sonny Rao <sonnyrao@chromium.org> - 2017-03-02 01:10 +0100
        Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays  on Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-02 01:50 +0100

csiph-web