Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590617

Re: [Outreachy kernel] [PATCH] staging: speakup: Comparison to NULL could be written

Show all headers | View raw

On Wed, 2017-03-01 at 20:58 +0100, Julia Lawall wrote:
> 
> On Thu, 2 Mar 2017, Arushi Singhal wrote:
> 
> > Fixed coding style for null comparisons in speakup driver to be more
> > consistant with the rest of the kernel coding style.

And Arushi, please use checkpatch on your proposed
patches before sending them.

$ ./scripts/checkpatch.pl ~/staging-speakup-Comparison-to-NULL-could-be-written.patch  --nosummary
WARNING: 'consistant' may be misspelled - perhaps 'consistent'?
#18: 
consistant with the rest of the kernel coding style.

CHECK: Avoid CamelCase: <CT_Off>
#138: FILE: drivers/staging/speakup/main.c:1512:
+	if (!synth || up_flag || spk_shut_up || cursor_track == CT_Off) {

ERROR: space prohibited before that close parenthesis ')'
#147: FILE: drivers/staging/speakup/main.c:1708:
+	if (spk_shut_up || !synth ) {

ERROR: space prohibited before that close parenthesis ')'
#156: FILE: drivers/staging/speakup/main.c:1725:
+	if ((vc->vc_num != fg_console) || spk_shut_up || !synth )

ERROR: space prohibited before that close parenthesis ')'
#183: FILE: drivers/staging/speakup/main.c:1813:
+	if (!p_header )

ERROR: space prohibited before that close parenthesis ')'
#210: FILE: drivers/staging/speakup/main.c:2068:
+	if (!synth )

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: speakup: Comparison to NULL could be written Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-01 20:40 +0100
  Re: [Outreachy kernel] [PATCH] staging: speakup: Comparison to NULL  could be written Julia Lawall <julia.lawall@lip6.fr> - 2017-03-01 21:10 +0100
    Re: [Outreachy kernel] [PATCH] staging: speakup: Comparison to NULL  could be written Joe Perches <joe@perches.com> - 2017-03-01 21:40 +0100
  Re: [PATCH] staging: speakup: Comparison to NULL could be written David Daney <ddaney.cavm@gmail.com> - 2017-03-01 23:40 +0100

csiph-web