Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590596

Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 01, 2017 at 10:44:16AM -0600, Jeremy Linton wrote:

> Right, there also appears to be dependency issues. Its like the
> regulator should be pulling in the parent pmic rather than the current

No, why would it do that?  The regulator can't be instantiated without
the parent so it can't do anything until the parent appears.

> situation where the pmic loads, the mmc subsystem loads, but then
> triggers hung task timeouts until the regulator is manually loaded.

If MMC needs a regulator it should be deferring probe until the
regulator appears.

> Worse, because the pmic isn't being held by the regulator you get this
> if the pmic is unloaded.
> 
> [31695.158053] ------------[ cut here ]------------
> [31695.162713] WARNING: CPU: 4 PID: 1729 at
> drivers/regulator/core.c:4136 regulator_unregister+0xfc/0x104

This is nothing to do with the parent, this is telling you that you're
removing a device which is currently in use which is obviously not going
to go well.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads Jeremy Linton <lintonrjeremy@gmail.com> - 2017-03-01 17:50 +0100
  Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads Mark Brown <broonie@kernel.org> - 2017-03-01 20:50 +0100

csiph-web