Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590410

Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in try_fmt and g_fmt

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le mercredi 01 mars 2017 à 14:12 +0100, Andrzej Hajda a écrit :
> - on output side you have encoded bytestream - you cannot say about
> interlacing in such case, so the only valid value is NONE,
> - on capture side you have decoded frames, and in this case it
> depends
> on the device and driver capabilities, if the driver/device does not
> support (de-)interlacing (I suppose this is MFC case), interlace type
> field should be filled according to decoded bytestream header (on
> output
> side), but no direct copying from output side!!!

I think we need some nuance here for this to actually be usable. If the
information is not provided by the driver (yes, hardware is limiting
sometimes), it would make sense to copy over the information that
userspace provided. Setting NONE is just the worst approximation in my
opinion.

About MFC, it will be worth trying to read the DISPLAY_STATUS after the
headers has been processed. It's not clearly stated in the spec if this
will be set or not.

Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in try_fmt and g_fmt Thibault Saunier <thibault.saunier@osg.samsung.com> - 2017-03-01 13:00 +0100
  Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in  try_fmt and g_fmt Andrzej Hajda <a.hajda@samsung.com> - 2017-03-01 14:30 +0100
    Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in  try_fmt and g_fmt Thibault Saunier <thibault.saunier@osg.samsung.com> - 2017-03-01 14:50 +0100
    Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in  try_fmt and g_fmt Thibault Saunier <thibault.saunier@osg.samsung.com> - 2017-03-01 16:00 +0100
    Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field'  in try_fmt and g_fmt Nicolas Dufresne <nicolas.dufresne@collabora.com> - 2017-03-01 16:30 +0100
    Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field'  in try_fmt and g_fmt Nicolas Dufresne <nicolas.dufresne@collabora.com> - 2017-03-01 16:30 +0100
      Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in  try_fmt and g_fmt Andrzej Hajda <a.hajda@samsung.com> - 2017-03-02 09:00 +0100
  Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in  try_fmt and g_fmt Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-10 11:50 +0100

csiph-web