Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590369

RE: [PATCH 1/1] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

From Dexuan Cui <decui@microsoft.com>
Newsgroups linux.kernel
Subject RE: [PATCH 1/1] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't
Date 2017-03-01 15:50 +0100
Message-ID <tgdJM-4r7-33@gated-at.bofh.it> (permalink)
References <tfKRr-1n8-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> From: kys@exchange.microsoft.com [mailto:kys@exchange.microsoft.com]
> Sent: Tuesday, February 28, 2017 07:18
> To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> ...
> From: Dexuan Cui <decui@microsoft.com>
> 
> If the daemon is NOT running at all, when we disable the util device from
> Hyper-V Manager (or sometimes the host can rescind a util device and then
> re-offer it), we'll hang in util_remove -> hv_kvp_deinit ->
> wait_for_completion(&release_event), because this code path doesn't run:
> hvt_op_release -> ... -> kvp_on_reset -> complete(&release_event).
> 
> Due to this, we even can't reboot the VM properly.
> 
> The patch tracks if the dev file is opened or not, and we only need to
> wait if it's opened.
> 
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> 
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ...

Please ignore this patch, since Vitaly posted a better fix instead.

Thanks,
-- Dexuan

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't kys@exchange.microsoft.com - 2017-02-28 09:00 +0100
  RE: [PATCH 1/1] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-03-01 15:50 +0100
  RE: [PATCH 1/1] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't KY Srinivasan <kys@microsoft.com> - 2017-03-05 01:20 +0100

csiph-web