Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590243
| From | Eric Blake <eblake@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] vfs: implement fchmodat2() syscall |
| Date | 2017-03-01 12:00 +0100 |
| Message-ID | <tga9d-1UD-27@gated-at.bofh.it> (permalink) |
| References | <tfTrH-7ry-3@gated-at.bofh.it> <tfUH8-8cC-35@gated-at.bofh.it> <tga9d-1UD-29@gated-at.bofh.it> |
| Organization | Red Hat, Inc. |
[Multipart message — attachments visible in raw view] - view raw
On 02/28/2017 12:41 PM, Greg Kurz wrote: >>> +++ b/include/linux/syscalls.h >>> @@ -775,6 +775,8 @@ asmlinkage long sys_futimesat(int dfd, const char __user *filename, >>> asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode); >>> asmlinkage long sys_fchmodat(int dfd, const char __user * filename, >>> umode_t mode); >>> +asmlinkage long sys_fchmodat2(int dfd, const char __user *filename, >>> + umode_t mode, int flag); >>> asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user, >>> gid_t group, int flag); >> >> Is the indentation off here? >> > > This is linux style indent with tabs+spaces. FWIW it is displayed correctly > in vi and emacs (I've simply copied the sys_fchmodat() declaration). Sorry for the noise; I see that it is correct now, since fchmodat2 is one bye longer than fchmodat or fchownat. Sometimes, I wish I could convince my mailer to display leading tabs as exactly 8 spaces rather than to the next 8-space tab stop, so that prefixed characters that aren't tab-stop aligned don't mess with the actual visual output. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] vfs: implement fchmodat2() syscall Greg Kurz <groug@kaod.org> - 2017-02-28 18:10 +0100
[PATCH 2/2] x86: wire up fchmodat2() syscall Greg Kurz <groug@kaod.org> - 2017-02-28 18:10 +0100
Re: [PATCH 1/2] vfs: implement fchmodat2() syscall Eric Blake <eblake@redhat.com> - 2017-02-28 19:30 +0100
Re: [PATCH 1/2] vfs: implement fchmodat2() syscall Eric Blake <eblake@redhat.com> - 2017-03-01 12:00 +0100
Re: [PATCH 1/2] vfs: implement fchmodat2() syscall Greg Kurz <groug@kaod.org> - 2017-03-01 12:50 +0100
Re: [PATCH 1/2] vfs: implement fchmodat2() syscall Michael Kerrisk <mtk.manpages@gmail.com> - 2017-03-01 10:10 +0100
csiph-web