Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1591983

Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device
Date 2017-03-03 15:30 +0100
Message-ID <tgWnv-2po-1@gated-at.bofh.it> (permalink)
References <tgD1v-5Gf-9@gated-at.bofh.it> <tgD1v-5Gf-11@gated-at.bofh.it> <tgD1v-5Gf-7@gated-at.bofh.it> <tgWnv-2po-3@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw


On Thu, 2017-03-02 at 13:11 -0600, Brijesh Singh wrote:
> Hi Mark,
> 
> On 03/02/2017 11:39 AM, Mark Rutland wrote:
> > On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote:

> > > 
> > > +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \
> > >  	    ccp-ops.o \
> > >  	    ccp-dev-v3.o \
> > >  	    ccp-dev-v5.o \
> > > -	    ccp-platform.o \
> > >  	    ccp-dmaengine.o
> > 
> > It looks like ccp-platform.c has morphed into sp-platform.c (judging
> > by
> > the compatible string and general shape of the code), and the
> > original
> > ccp-platform.c is no longer built.
> > 
> > Shouldn't ccp-platform.c be deleted by this patch?
> > 
> 
> Good catch. Both ccp-platform.c and ccp-pci.c should have been
> deleted 
> by this patch. I missed deleting it, will fix in next rev.

Don't forget to use -M -C when preparing / sending patches.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure  Processor device Mark Rutland <mark.rutland@arm.com> - 2017-03-02 18:50 +0100
  Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure  Processor device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-03 15:30 +0100

csiph-web