Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591881

[PATCH v3 5/5] acpi/processor: Check for duplicate processor ids at hotplug time

Show all headers | View raw

The check for duplicate processor ids happens at boot time based on the
ACPI table contents, but the final sanity checks for a processor happen
at hotplug time.

At hotplug time, where the physical information is available, which might
differ from the ACPI table information, a check for duplicate processor
ids is missing.

Add it to the hotplug checks and rename the function so it better
reflects its purpose.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Tested-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 drivers/acpi/acpi_processor.c | 13 ++++++++++---
 include/linux/acpi.h          |  2 +-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index 9a98d7e..3ce2e9e 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -280,6 +280,13 @@ static int acpi_processor_get_info(struct acpi_device *device)
 		pr->acpi_id = value;
 	}
 
+	if (acpi_duplicate_processor_id(pr->acpi_id)) {
+		dev_err(&device->dev,
+			"Failed to get unique processor _UID (0x%x)\n",
+			pr->acpi_id);
+		return -ENODEV;
+	}
+
 	pr->phys_id = acpi_get_phys_id(pr->handle, device_declaration,
 					pr->acpi_id);
 	if (invalid_phys_cpuid(pr->phys_id))
@@ -580,7 +587,7 @@ static struct acpi_scan_handler processor_container_handler = {
 static int nr_unique_ids __initdata;
 
 /* The number of the duplicate processor IDs */
-static int nr_duplicate_ids __initdata;
+static int nr_duplicate_ids;
 
 /* Used to store the unique processor IDs */
 static int unique_processor_ids[] __initdata = {
@@ -588,7 +595,7 @@ static int unique_processor_ids[] __initdata = {
 };
 
 /* Used to store the duplicate processor IDs */
-static int duplicate_processor_ids[] __initdata = {
+static int duplicate_processor_ids[] = {
 	[0 ... NR_CPUS - 1] = -1,
 };
 
@@ -679,7 +686,7 @@ void __init acpi_processor_check_duplicates(void)
 						NULL, NULL);
 }
 
-bool __init acpi_processor_validate_proc_id(int proc_id)
+bool acpi_duplicate_processor_id(int proc_id)
 {
 	int i;
 
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 63a7519..9b05886 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -287,7 +287,7 @@ static inline bool invalid_phys_cpuid(phys_cpuid_t phys_id)
 }
 
 /* Validate the processor object's proc_id */
-bool acpi_processor_validate_proc_id(int proc_id);
+bool acpi_duplicate_processor_id(int proc_id);
 
 #ifdef CONFIG_ACPI_HOTPLUG_CPU
 /* Arch dependent functions for cpu hotplug support */
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Do repair works for the mapping of cpuid <-> nodeid Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-03 09:20 +0100
  [PATCH v3 4/5] acpi/processor: Implement DEVICE operator for processor enumeration Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-03 09:30 +0100
    [tip:x86/acpi] acpi/processor: Implement DEVICE operator for  processor enumeration tip-bot for Dou Liyang <tipbot@zytor.com> - 2017-03-11 14:50 +0100
  Re: [PATCH v3 0/5] Do repair works for the mapping of cpuid <->  nodeid Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-03 09:40 +0100
    Re: [PATCH v3 0/5] Do repair works for the mapping of cpuid <->  nodeid Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-06 03:20 +0100
  [PATCH v3 1/5] Revert"x86/acpi: Set persistent cpuid <-> nodeid mapping when booting" Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-03 10:20 +0100
    [tip:x86/acpi] Revert "x86/acpi: Set persistent cpuid <-> nodeid  mapping when booting" tip-bot for Dou Liyang <tipbot@zytor.com> - 2017-03-11 14:50 +0100
  [PATCH v3 5/5] acpi/processor: Check for duplicate processor ids at hotplug time Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-03 12:50 +0100
    [tip:x86/acpi] acpi/processor: Check for duplicate processor ids at  hotplug time tip-bot for Dou Liyang <tipbot@zytor.com> - 2017-03-11 14:50 +0100

csiph-web