Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591660

Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

Show all headers | View raw

Hi Poitr,

On 2017/3/2 21:47, Piotr Sroka wrote:
> Fix the code to avoid changing bus width if HS400ES mode is selected.
>

Thanks for catching this, but Guenter posted a fix[1] already. :)

[1]: https://patchwork.kernel.org/patch/9599261/

> Signed-off-by: Piotr Sroka <piotrs@cadence.com>
> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd7228..c7d9c9f 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>  		err = mmc_select_hs400(card);
>  		if (err)
>  			goto free_card;
> -	} else {
> +	} else if (!mmc_card_hs400(card)) {
>  		/* Select the desired bus width optionally */
>  		err = mmc_select_bus_width(card);
>  		if (err > 0 && mmc_card_hs(card)) {
>


-- 
Best Regards
Shawn Lin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: core: fix changing bus witdh in hs400es mode Piotr Sroka <piotrs@cadence.com> - 2017-03-02 15:00 +0100
  Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-03 04:50 +0100
    RE: [PATCH] mmc: core: fix changing bus witdh in hs400es mode Piotr Sroka <piotrs@cadence.com> - 2017-03-03 08:20 +0100

csiph-web