Re: [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency properties for exynos3250 dts

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency properties for exynos3250 dts
Date	2017-03-03 01:50 +0100
Message-ID	<tgJzY-1FS-3@gated-at.bofh.it> (permalink)
References	<tgw9I-Sh-27@gated-at.bofh.it> <tgxfr-1z0-3@gated-at.bofh.it> <tgxfr-1z0-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Hoegeun,

On Thu, Mar 02, 2017 at 07:20:14PM +0900, Hoegeun Kwon wrote:
> The OF graph is not needed because the panel is a child of dsi. So
> added the burst and esc clock frequency properties to the parent (DSI
> node), taking into account the bisectability problem so that remove
> the OF graph from DSI node.

nitpick:

1. bisectability is not a problem (and for bisectability you
   should not mention it in the commit log, you would confuse
   bisecting people)

2. you should use the imperative form, not "added the burst... "
   but "add the burst..."

Same for the other patches.

Andi

Thread

[PATCH v3 0/7] Fix the parse_dt of exynos dsi and remove the OF graph Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 11:40 +0100
  [PATCH v3 3/7] arm: dts: Add the burst and esc clock frequency  properties for exynos4412 dts Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 11:40 +0100
  [PATCH v3 4/7] arm: dts: Add the burst and esc clock frequency  properties for exynos4210 dts Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 11:40 +0100
  [PATCH v3 1/7] arm64: dts: exynos: Add the burst and esc clock  frequency properties for exynos5433 dts Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 11:40 +0100
  [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency  properties for exynos3250 dts Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 12:40 +0100
    Re: [PATCH v3 2/7] arm: dts: Add the burst and esc clock frequency  properties for exynos3250 dts Andi Shyti <andi.shyti@samsung.com> - 2017-03-03 01:50 +0100
  [PATCH v3 6/7] arm64: dts: exynos: Remove the OF graph from DSI node Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 12:40 +0100
  [PATCH v3 5/7] drm/exynos: dsi: Fix the parse_dt function Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-03-02 12:40 +0100
  Re: [PATCH v3 0/7] Fix the parse_dt of exynos dsi and remove the OF  graph Andi Shyti <andi.shyti@samsung.com> - 2017-03-03 01:40 +0100
    Re: [PATCH v3 0/7] Fix the parse_dt of exynos dsi and remove the OF  graph Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-04 09:30 +0100

csiph-web