Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature
Date	2017-03-03 01:00 +0100
Message-ID	<tgINA-13L-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <t0Ytl-4D1-41@gated-at.bofh.it> <tfVWy-rZ-9@gated-at.bofh.it> <tgqQF-5t3-1@gated-at.bofh.it> <tgsfL-6BU-1@gated-at.bofh.it> <tgAdk-3As-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 02, 2017 at 06:39:49AM -0800, Matthew Wilcox wrote:
> On Thu, Mar 02, 2017 at 01:45:35PM +0900, byungchul.park wrote:
> > From: Matthew Wilcox [mailto:willy@infradead.org]
> > > On Tue, Feb 28, 2017 at 07:15:47PM +0100, Peter Zijlstra wrote:
> > > > (And we should not be returning to userspace with locks held anyway --
> > > > lockdep already has a check for that).
> > > 
> > > Don't we return to userspace with page locks held, eg during async
> > > directio?
> > 
> > Hello,
> > 
> > I think that the check when returning to user with crosslocks held
> > should be an exception. Don't you think so?
> 
> Oh yes.  We have to keep the pages locked during reads, and we have to
> return to userspace before I/O is complete, therefore we have to return
> to userspace with pages locked.  They'll be unlocked by the interrupt
> handler in page_endio().

Agree.

> Speaking of which ... this feature is far too heavy for use in production
> on pages.  You're almost trebling the size of struct page.  Can we
> do something like make all struct pages share the same lockdep_map?
> We'd have to not complain about holding one crossdep lock and acquiring
> another one of the same type, but with millions of pages in the system,
> it must surely be creating a gargantuan graph right now?

Um.. I will try it for page locks to work with one lockmap. That is also
what Peterz pointed out and what I worried about when implementing..

Thanks for your opinion.

Thread

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Matthew Wilcox <willy@infradead.org> - 2017-03-02 05:50 +0100
  RE: [PATCH v5 06/13] lockdep: Implement crossrelease feature "byungchul.park" <byungchul.park@lge.com> - 2017-03-02 07:20 +0100
    Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Matthew Wilcox <willy@infradead.org> - 2017-03-02 15:50 +0100
      Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Byungchul Park <byungchul.park@lge.com> - 2017-03-03 01:00 +0100
        Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Byungchul Park <byungchul.park@lge.com> - 2017-03-05 09:10 +0100

csiph-web