Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer

From	SIMRAN SINGHAL <singhalsimran0@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer
Date	2017-03-02 23:30 +0100
Message-ID	<tgHot-hN-5@gated-at.bofh.it> (permalink)
References	<tgGiK-80q-5@gated-at.bofh.it> <tgGsp-852-7@gated-at.bofh.it> <tgH58-85-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
>> index 2379901..d745b93 100644
>> --- a/drivers/staging/rts5208/rtsx_transport.c
>> +++ b/drivers/staging/rts5208/rtsx_transport.c
>> @@ -767,7 +767,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip, u8 card, void *buf, size_t len,
>>
>>       if (use_sg) {
>>               err = rtsx_transfer_sglist_adma(chip, card,
>> -                                             (struct scatterlist *)buf,
>> +                                             buf,
>
> Here too, buf doesn't need its own line.
>
I will send v2.
> julia
>
>>                                               use_sg, dma_dir, timeout);
>>       } else {
>>               err = rtsx_transfer_buf(chip, card, buf, len, dma_dir, timeout);
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488489544-25941-4-git-send-email-singhalsimran0%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-02 22:30 +0100
  Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary  cast on void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-02 23:10 +0100
    Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove  unnecessary cast on void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-02 23:30 +0100

csiph-web