Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591464

Re: [PATCH] x86/hpet: Prevent might sleep splat on resume

Show all headers | View raw

On (03/01/17 21:10), Thomas Gleixner wrote:
> Sergey reported a might sleep warning triggered from the hpet resume
> path. It's caused by the call to disable_irq() from interrupt disabled
> context.
> 
> The problem with the low level resume code is that it is not accounted as a
> special system_state like we do during the boot process. Calling the same
> code during system boot would not trigger the warning. That's inconsistent
> at best.
> 
> In this particular case it's trivial to replace the disable_irq() with
> disable_hardirq() because this particular code path is solely used from
> system resume and the involved hpet interrupts can never be force threaded.
> 
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org


Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

thanks!

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86/hpet: Prevent might sleep splat on resume Thomas Gleixner <tglx@linutronix.de> - 2017-03-01 22:40 +0100
  [tip:x86/urgent] x86/hpet: Prevent might sleep splat on resume tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-03-02 09:50 +0100
  Re: [PATCH] x86/hpet: Prevent might sleep splat on resume Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-02 22:20 +0100

csiph-web