Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT
Date	2017-03-02 19:30 +0100
Message-ID	<tgDEd-6cP-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <tfNPj-3Bl-7@gated-at.bofh.it> <tfRJf-6ds-9@gated-at.bofh.it> <tfXOG-1BX-19@gated-at.bofh.it> <tggHE-6rz-15@gated-at.bofh.it> <tgBCq-4RH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mayurkumar

On 3/2/2017 11:05 AM, Patel, Mayurkumar wrote:
>>
>> Hi Bjorn,
>>
>> On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote:
>>>> I was trying to figure out when to use saved values vs. the values in
>>>> registers by looking at the enable_cnt.
>>>> enable_cnt is 0 during boot on my system.
>>> enable_cnt for the root port on my system is set to 1 for "root port" already without saving
>>> any ASPM related settings.
>>>
>>>
>>
>> What would be the best way to figure out when to save power-on values from
>> the registers?
>>
> 
> I can upload the diffs) because enable_cnt in pci_enable_device() can be triggered
> from multiple places at boot time so it might not be safe to use it? 

Go ahead and share your diff. It doesn't hurt to look at other alternatives.

> 
> @Kaya/Bjorn: Do you have any other suggestions or Could you also please help by comment what would make sense?
> 
> 
>> --
>> Sinan Kaya
>> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
>> Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Christian Lamprechter
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> 


-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Thread

Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for  POLICY_DEFAULT Sinan Kaya <okaya@codeaurora.org> - 2017-03-01 19:00 +0100
  RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for  POLICY_DEFAULT "Patel, Mayurkumar" <mayurkumar.patel@intel.com> - 2017-03-02 17:20 +0100
    Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for  POLICY_DEFAULT Sinan Kaya <okaya@codeaurora.org> - 2017-03-02 19:30 +0100
      RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for  POLICY_DEFAULT "Patel, Mayurkumar" <mayurkumar.patel@intel.com> - 2017-03-03 10:50 +0100
        Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for  POLICY_DEFAULT okaya@codeaurora.org - 2017-03-03 11:40 +0100

csiph-web