Re: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself
Date	2017-03-02 18:00 +0100
Message-ID	<tgCf8-56J-35@gated-at.bofh.it> (permalink)
References	<tgylc-2jr-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu,  2 Mar 2017 10:47:49 +0100
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> Waiting for release_event in all three drivers introduced issues on release
> as on_reset() hook is not always called. E.g. if the device was never
> opened we will never get the completion.
> 
> Move the waiting code to hvutil_transport_destroy() and make sure it is
> only called when the device is open. hvt->lock serialization should
> guarantee the absence of races.
> 
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue")
> Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue")
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Acked-by: Stephen Hemminger <sthemmin@microsoft.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] Drivers: hv: util: move waiting for release to  hv_utils_transport itself Stephen Hemminger <stephen@networkplumber.org> - 2017-03-02 18:00 +0100

csiph-web