Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap

From	Auger Eric <eric.auger@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap
Date	2017-03-02 17:10 +0100
Message-ID	<tgBsJ-4MC-11@gated-at.bofh.it> (permalink)
References	<tgAQ1-4iq-5@gated-at.bofh.it> <tgAQ1-4iq-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 02/03/2017 16:19, Marc Zyngier wrote:
> On 02/03/17 15:11, Mian Yousaf Kaukab wrote:
>> Fix following build error for s390:
>> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
>> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
>>
>> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
>> ---
>> History:
>> v1:
>>  -Return false instead of true as suggested by Marc and Eric.
>>  -Drop 2/2
>>
>>  include/linux/irqdomain.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
>> index 188eced6813e..9f3616085423 100644
>> --- a/include/linux/irqdomain.h
>> +++ b/include/linux/irqdomain.h
>> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>>  {
>>  	return NULL;
>>  }
>> +static inline bool irq_domain_check_msi_remap(void)
>> +{
>> +	return false;
>> +}
>>  #endif /* !CONFIG_IRQ_DOMAIN */
>>  
>>  #endif /* _LINUX_IRQDOMAIN_H */
>>
> 
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks!

Eric
> 
> I'll queue that now.
> 
> Thanks,
> 
> 	M.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap Marc Zyngier <marc.zyngier@arm.com> - 2017-03-02 16:30 +0100
  Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap Auger Eric <eric.auger@redhat.com> - 2017-03-02 17:10 +0100

csiph-web