Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1591163

Re: e1000_netpoll() , BUG: sleeping function called from invalid context

From Gabriel C <nix.or.die@gmail.com>
Newsgroups linux.kernel
Subject Re: e1000_netpoll() , BUG: sleeping function called from invalid context
Date 2017-03-02 16:00 +0100
Message-ID <tgAn1-3FV-37@gated-at.bofh.it> (permalink)
References (7 earlier) <tggoj-6jU-39@gated-at.bofh.it> <tgl4B-1eE-11@gated-at.bofh.it> <tgl4B-1eE-9@gated-at.bofh.it> <tgmal-1Yy-3@gated-at.bofh.it> <tgnpM-30D-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 02.03.2017 01:04, Gabriel C wrote:
>
>
>>> Does the patch below fix it?
>>
>> I'll test you patch in a bit and let you know.
>>
>
> It seem to work.
>
> But to be really sure I let the box running with this setup over night.
>

Also with 4.10.1 + your patch all seems fine..

The box is up 13 hours now and I cannot trigger the BUG()..

>>> 	
>>> 8<--------------
>>>
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -6716,19 +6716,19 @@ static irqreturn_t e1000_intr_msix(int _
>>>
>>>  		vector = 0;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_intr_msix_rx(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>
>>>  		vector++;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_intr_msix_tx(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>
>>>  		vector++;
>>>  		msix_irq = adapter->msix_entries[vector].vector;
>>> -		disable_irq(msix_irq);
>>> +		disable_hardirq(msix_irq);
>>>  		e1000_msix_other(msix_irq, netdev);
>>>  		enable_irq(msix_irq);
>>>  	}
>>>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Thomas Gleixner <tglx@linutronix.de> - 2017-03-01 18:40 +0100
  Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Thomas Gleixner <tglx@linutronix.de> - 2017-03-01 23:40 +0100
    Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Gabriel C <nix.or.die@gmail.com> - 2017-03-02 00:50 +0100
      Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Gabriel C <nix.or.die@gmail.com> - 2017-03-02 02:10 +0100
        Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Gabriel C <nix.or.die@gmail.com> - 2017-03-02 16:00 +0100
  Re: e1000_netpoll() , BUG: sleeping function called from invalid  context Gabriel C <nix.or.die@gmail.com> - 2017-03-01 23:40 +0100

csiph-web