Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591165

Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks

Show all headers | View raw

On Thu, 2 Mar 2017, simran singhal wrote:

> Resolve strict checkpatch USLEEP_RANGE checks by converting delays and
> sleeps as described in ./Documentation/timers/timers-howto.txt.
>
> CHECK: usleep_range is preferred over udelay; see Documentation/
> timers/timers-howto.txt
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index c1feccf..cd35e64 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  		break;
>  	case 2:		/* first byte after command */
>  		if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> -			udelay(33);
> +			usleep_range(33, 100);

How did you choose the upper limit.

I believe that Greg previously suggested not to make these changes if you
have no way to test them.

julia


>  			if (nvec->rx->data[0] != 0x01) {
>  				dev_err(nvec->dev,
>  					"Read without prior read command\n");
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  	 * We experience less incomplete messages with this delay than without
>  	 * it, but we don't know why. Help is appreciated.
>  	 */
> -	udelay(100);
> +	usleep_range(100, 200);
>
>  	return IRQ_HANDLED;
>  }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170302142418.GA16773%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks simran singhal <singhalsimran0@gmail.com> - 2017-03-02 15:30 +0100
  Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGEcheckpatch checks Marc Dietrich <marvin24@gmx.de> - 2017-03-02 16:00 +0100
    Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup  USLEEP_RANGEcheckpatch checks Thierry Reding <thierry.reding@gmail.com> - 2017-03-08 14:00 +0100
  Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE  checkpatch checks Julia Lawall <julia.lawall@lip6.fr> - 2017-03-02 16:00 +0100
    Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE  checkpatch checks Julia Lawall <julia.lawall@lip6.fr> - 2017-03-02 16:20 +0100
      Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE  checkpatch checks Julia Lawall <julia.lawall@lip6.fr> - 2017-03-02 18:00 +0100

csiph-web